-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed translations for passwordMismatch #14570
Changed translations for passwordMismatch #14570
Conversation
Hi there @rasmusmedj, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hey @rasmusmedj! Thanks a lot for the PR, someone on the core collaborators team will review this soon 😺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rasmusmedj I can see the problem, but the new message is not very clear (and I'm not sure mismatch is a word used a lot in Danish). If this needs to change to be generic in all situations it would become a long text, something like: "If this is a new account then the passwords you entered don't match, if you're changing your password then the confirmed password doesn't match the new password". Of course this is not a workable text either.
I would recommend adding another translation key instead and use that in the context, so wherever we use the translation during a Create then use one of them and when we use it during a password change, use the other.
Since we haven't heard back for a while, I'll close this one. Feel free to start a new PR taking the comments above on board! |
Fixes #14528
Description
Because of ASP standards, they give us the errorCode "PasswordMismatch" for both changing a password and creating a new one.
Thus we can't have two different translations. This is also why the current translation is misleading when changing password and the current password is a mismatch.
How to test